Logical condition always true
Open
- Dominant language
- C++
- Stars
- 26
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Description
/src/im/imstaff.cpp line 640
Code:
if ( (threshold_in_percent != 0) || (threshold_in_percent != 100) ) // <-- probably &&
staff_threshold = m_med / (100 / threshold_in_percent); // threshold_in_percent
Contributor guide
No contributing guide indexed for this repository
Research direction
Open /src/im/imstaff.cpp around line 640 and inspect the threshold_in_percent condition and the nearby staff_threshold calculation. Confirm the intended boundary behavior for 0 and 100, correct the always-true logic, and verify that threshold handling no longer permits invalid division.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100