DDMAL / DDMAL/Rodan

CI test cases can be passed when they should fail

Open
#987 0 comments 0 reactions 1 assignee Claimed by @softcat477 View on GitHub
Dominant language
CSS
Stars
46
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Recently, non-interactive classifier stopped working but it went undiscovered because the CI tests were passing. I have two theories why.

1. The CI test container's environment was too different from Py3 celery's

2. Each job has a CI test defined in its test_my_task method. It takes a test case object and does assertions. However if the job crashes before an assertion is run, then the test case is passed.

Example: https://github.com/DDMAL/Rodan/issues/984

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.