DDMAL / DDMAL/Rodan

Grouping in IC causing multiple (NON duplicated) elements

Open
#972 1 comment 0 reactions 1 assignee Claimed by @sabrina0822 View on GitHub
bug Interactive Classifier priority: Medium
Dominant language
CSS
Stars
46
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Upon inspecting Taz's folio I noticed a really strange occurance by looking at his Neon output.

Original folio:
![Screenshot 2023-06-16 at 12 04 14 PM](https://github.com/DDMAL/Rodan/assets/90227881/e8ae0ffb-94d3-432a-9424-49d351850df8)
Our output:
![Screenshot 2023-06-16 at 11 59 17 AM](https://github.com/DDMAL/Rodan/assets/90227881/32935f8f-192b-4910-9415-0a03e127128a)
There are 16 neumes in that big grouping, I'm assuming 15 belong to the torculus and 1 to the regular punctum.

Original folio:
![Screenshot 2023-06-16 at 12 04 26 PM](https://github.com/DDMAL/Rodan/assets/90227881/da83d74e-f563-4c64-b993-ee290766bbd9)
Our output:
![Screenshot 2023-06-16 at 11 59 21 AM](https://github.com/DDMAL/Rodan/assets/90227881/b086e6b5-a2e6-4627-bf6b-c625d171f244)

The torculus on the left has 6 neumes and the torculus on the right has 6 neumes.

Here is my best guess:
Unlike the previous issue with IC, these repeated elements don't have the exact same coordinates.

In the first example above, I'm assuming there are 5 repeated torculi, hence the 15 neumes. This correlates with the number of elements that were grouped together in interactive classifier to make up the torculus.

![Screenshot 2023-06-16 at 12 10 20 PM](https://github.com/DDMAL/Rodan/assets/90227881/387ca6ef-01cc-4123-b41d-d851cff62eb1)

For the second example, each of the torculus was a combination of two elements that were grouped together which would explain there being 6 neumes for each one.

Upon inspecting the interactive classifier output, there are 9 identified torculus for this folio which is simply incorrect but correlates to the number of elements that were grouped together to make up the three torculi.

It seems that the manual grouping element of IC is not working. Instead of creating a new element that combines all of the elements it's assigning the torculus label to each element which causes a lot of repeats in different coordinates.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.