DDMAL / DDMAL/Rodan

Heuristic pitch finding fails sometimes (can be reproduced)

Open
#1,220 6 comments 0 reactions 1 assignee Claimed by @homework36 View on GitHub
bug Priority: HIGH
Dominant language
CSS
Stars
46
Forks
13
PR merge metrics
No merged PRs in 30d

Description

Occasionally, when running an e2e OMR with an MS73 folio, the Heuristic_Pitch_Finding job with a message like this:

```
RuntimeError: Image view dimensions out of range for data nrows 42 offset_y 511 data nrows 41
data offset_y 512 ncols 56 offset_x 2560 data ncols 252 data offset_x 2560
```

The numbers change, but the general message is always the same. We don't know why this is happening, but we do know this:
- We can't predict when the job will fail, but if the job _does_ fail it will fail consistently with the same resources.
- Whether the job fails might be related to how well the layer separation happens. We have two sets of layer separation models for MS73. If we run a folio with its "correct" models, the Heuristic job will probably work. If we run the same folio with the other set of models, the Heuristic job will probably fail.

Folio 133 is an example of this. If you put these resources into the Heuristic_Pitch_Finding job, the job will run correctly:

[Miyao Staff Finding - 133 finished.json](https://github.com/user-attachments/files/17408728/Miyao.Staff.Finding.-.133.finished.json)
[Non-Interactive Classifier - 133 finished.xml.zip](https://github.com/user-attachments/files/17408730/Non-Interactive.Classifier.-.133.finished.xml.zip)

And if you put these resources in instead, the job will fail:

[Miyao Staff Finding - 133 failed.json](https://github.com/user-attachments/files/17408733/Miyao.Staff.Finding.-.133.failed.json)
[Non-Interactive Classifier - 133 failed.xml.zip](https://github.com/user-attachments/files/17408736/Non-Interactive.Classifier.-.133.failed.xml.zip)

I was bold and put a high priority, because we can't run e2e OMR workflows if this job is failing.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.