Golden test fixtures don't yet carry a value they're now checked against
- Dominant language
- Rust
- Stars
- 3
- Forks
- 0
- Avg merge
- 1d 42m
- Merged PRs (30d)
- 11
Description
A new field was added to the golden test fixture format:
https://github.com/Cyphrme/Cyphr/blob/0bbaa9fd27939b06a465aa134aad7f1f8ee406db/rs/test-fixtures/src/golden.rs#L118-L125
...and is now checked when present:
https://github.com/Cyphrme/Cyphr/blob/0bbaa9fd27939b06a465aa134aad7f1f8ee406db/rs/cyphr/tests/golden_fixtures.rs#L160-L165
None of the ~47 already-committed fixture files carry this field, since they predate it, so the check above never actually runs against the persisted corpus — it's proven correct via a separate, dedicated round-trip test instead. A real regression-pinning value on disk is stronger than a same-code round-trip check; regenerating the fixture corpus to include this field would close the gap.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reading rs/test-fixtures/src/golden.rs around lines 118-125 and rs/cyphr/tests/golden_fixtures.rs around lines 160-165 to understand the new field and its check. Regenerate or update the roughly 47 persisted fixture files so they contain the field, then run the golden fixture tests; done means the on-disk corpus exercises the check rather than only the round-trip test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- Half a day
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100