CymChad / CymChad/BaseRecyclerViewAdapterHelper
BaseItemProvider存view的Id的集合,不应该用ArrayList
Open
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 24.6k
- Forks
- 5.2k
- PR merge metrics
- No merged PRs in 30d
Description
这两个viewIds应该用Set集合,否则如果不小心重复添加了id,listener会设置多次
BaseQuickAdapter里边用的就是Set,为什么不保持一致呢?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with library/src/main/java/com/chad/library/adapter/base/provider/BaseItemProvider.kt at lines 22-23, then compare the Set usage in BaseQuickAdapter.kt around line 453. Verify how the view IDs are registered and confirm that duplicate IDs cannot cause a listener to be set more than once.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100