CyberSource / CyberSource/cybersource-sdk-dotnet
Not extracting all certificates from keyfile
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 37
- Forks
- 53
- PR merge metrics
- No merged PRs in 30d
Description
NVPClient.RunTransaction() used to use X509Certificate2Collection.Import() to extract all certificates from a keyfile into a collection. This has been changed to now instantiate a certificate from the keyfile and add it to the collection instead. That means the collection will now only have one certificate whereas it used to have multiple. When using config.UseSignedAndEncrypted, the code will look for a merchant certificate AND a cybersource certificate ... and now fails. This bug seems to be repeated multiple times in NVPClient.cs, SoapClient.cs, and XmlClient.cs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing certificate handling in NVPClient.cs, SoapClient.cs, and XmlClient.cs, focusing on the keyfile collection behavior used by config.UseSignedAndEncrypted. Compare the current single-certificate construction with the prior collection import behavior. Done means each client can find both the merchant and cybersource certificates from a keyfile.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- payments
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100