Countly / Countly/countly-sdk-java

Consider replacing org.json dependency which uses a non-free license

Open
#13 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
6
Forks
2
Avg merge
2d 6h
Merged PRs (30d)
12

Description

When running Spring boot tests with the countly java SDK on the classpath, I noticed the same warning as in this SO question,
about having multiple implementations of JSONObject on the classpath. To avoid that, we can exclude either the json.org dependency of countly, or the com.vaadin.external.google:android-json dependency of spring-boot-starter-test.

Anyway, the real issue is, that org.json is licenced under a non-free license with a silly "don't use for evil" clause, as explained in this answer or in the openjson Readme. You might want to consider replacing the dependency on org.json.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the project's dependency declarations and the org.json usages, then run the Spring Boot tests that expose the duplicate JSONObject warning. Compare the available JSON alternatives and their licensing and compatibility; done means the non-free dependency is replaced without breaking the SDK or its tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.