Countly / Countly/countly-sdk-cpp
third-party JSON dependency included in header
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 34
- Forks
- 25
- PR merge metrics
- No merged PRs in 30d
Description
The third party dependency nlohmann/json is included in the header, which means clients of this SDK will also be pulling it in. this can conflict with a different but existing version of that library, and also means if a client is using a different JSON library, it now depends on multiple JSON libs. the path specified for that JSON dependency is also hardcoded
it would be great to move this dependency to the .cpp so clients don't need to worry about it
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the SDK's public headers and implementation files for the nlohmann/json include and the hardcoded dependency path. Move the dependency use into the .cpp implementation so clients are not required to pull in or resolve nlohmann/json through the header.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100