Countly / Countly/countly-sdk-cpp

No namespace

Open
#33 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
34
Forks
25
PR merge metrics
No merged PRs in 30d

Description

Without a namespace, the contents of the header polute the global namespace. in particular, the using json is quite unfortunate

clients of this SDK need to wrap the #include <countly.hpp> in a namespace as a work-around

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the countly.hpp header and locate the using json declaration and other top-level contents. The change is complete when including the header no longer pollutes the global namespace and existing SDK clients can still compile without the namespace workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
developer-experience
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.