CosmoStat / CosmoStat/shapepipe
Clean up object size usage
Open
@martinkilbinger is already working on this.
Since Jul 20, 2023.
clean up
- Dominant language
- Python
- Stars
- 18
- Forks
- 14
- Avg merge
- 8h 40m
- Merged PRs (30d)
- 10
Description
Various estimators of object size are used throughout the code:
- fwhm
- sigma (e.g. from HSM moment measurement)
- T = I_xx + I_yy (sum of second-order moments), also written as R^2, T approx 2 sigma^2
Units can be in pixels or arcsec/arcmin.
These should be unified and made clear.
Two functions to transform between some of those exist in sp_validation/galaxy.py, we should use and extend those.
In the code, replace hard-coded numbers 1.17741, 2.355.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.