CosmoStat / CosmoStat/shapepipe

Remove the SIP to PV conversion

Open
#612 3 comments 0 reactions 1 assignee View on GitHub

@lbaumo is already working on this.

Since Feb 15, 2023.

enhancement
Dominant language
Python
Stars
18
Forks
14
Avg merge
8h 40m
Merged PRs (30d)
10

Description

In the split_exp package we are converting the WCS PV keywords to SIP to read the WCS with astropy, and this is not necessary. At the moment astropy cannot read the current WCS because the TYPE of the WCS is set to RA--TAN instead of RA--TPV. This was not a problem in the past because astropy allows inconsistency between the TYPE and the provided keywords, but now it is more strict about it. Also the TAN and TPV conventions are the same. I would propose to remove the conversion in the pipeline and instead update the TYPE in the header to avoid the dependence to an external package and changing the original WCS.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.