CosmoStat / CosmoStat/shapepipe

[NEW FEATURE] rounded snr

Open
#603 3 comments 0 reactions 1 assignee View on GitHub

@lbaumo is already working on this.

Since Sep 6, 2023.

enhancement
Dominant language
Python
Stars
18
Forks
14
Avg merge
8h 40m
Merged PRs (30d)
10

Description

From Jarvis 2016 (DES SV shapes) "For NGMIX... we find significantly smaller selection biases when we use(S/N )r to select galaxies for shear measurement, as compared to using (S/N )w ."

This is because "if the PSF is approximately round, as is the case for our data, then more elliptical galaxies will have a lower estimated (S/N )w than round galaxies (holding flux constant). Thus if galaxies are selected according to their measured (S/N )w , the resulting galaxy catalogue will have a selection bias towards round shapes, which will bias the overall mean shear.

One null test we can do is plot vs snr

How to calculate snr_r

  1. calculate round r50 Question: should we use T_r to get r50? Judging from this quote we do: "That is, we take the model of the galaxy profile and apply a shear such that its ellipticity becomes zero. We do the same for the PSF, convolve these two profiles together, and then integrate over the pixels. "
  2. use the round r50 and [draw a new galaxy](in erin sheldon's ngmix code ngmix/fitting/galsim_results.py) with chosen model (gaussian, esponential, etc). see calc_s2n_r(self, pars) (in k space). Question: what do we do about the weights? from the code, it looks like we keep them the same. do we alter the psf?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.