CosmicMind / CosmicMind/Motion

Motion affects other 3-rd party animation libraries

Open
#74 9 comments 0 reactions 3 assignees Claimed by @OrkhanAlikhanov View on GitHub
bug investigate motion
Dominant language
Swift
Stars
1.8k
Forks
120
PR merge metrics
No merged PRs in 30d

Description

Hi there! First of all, I want to say that I love Motion a lot, it is a great thing which allows developers to do awesome stuff in their apps. I want to use it in our project a lot, but I am currently having several issues, and I would like to help finding and fixing them...

Along with Motion, I am using NVActivityIndicatorView, and I noticed that after several Motion transitions, my NVActivityIndicatorView animations work with some delay, and the more Motion transitions I perform, the worse it gets for NVActivityIndicatorView. Here is a video of a simple project I made. I tap "Animation" button to trigger NVActivityIndicatorView animation, it works fine. Then I do 10 Motion transitions and tap "Animation" again. You can see a slight freeze/delay. I repeat it 2 more times and it gets worse with every 10 transitions. In my real app with more complex views and transitions this thing is noticeable even after 2-3 transitions

[video.mp4.zip](https://github.com/CosmicMind/Motion/files/3594802/video.mp4.zip)
[tabbarissue.zip](https://github.com/CosmicMind/Motion/files/3594786/tabbarissue.zip)

I discovered that HeroTransitions has the same issue:
https://github.com/HeroTransitions/Hero/issues/256
And it happens not only with NVActivityIndicatorView but with other libraries too as you can see in that discussion

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.