CosmicMind / CosmicMind/Material

Memory leak with motionNavigationTransitionType in NavigationController

Open
#1,202 5 comments 0 reactions 1 assignee Claimed by @adamdahan View on GitHub
high priority investigate material
Dominant language
Swift
Stars
12k
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

I have memory leak with `motionNavigationTransitionType = .selectBy(presenting: .slide(direction: .left), dismissing: .slide(direction: .right))`

my simple implementation is:

```
import UIKit
import Material

class AppNavigationController: NavigationController {

open override func prepare() {
super.prepare()

isMotionEnabled = true
motionNavigationTransitionType = .selectBy(presenting: .slide(direction: .left), dismissing: .slide(direction: .right))

guard let v = navigationBar as? NavigationBar else { return }
v.dividerColor = Color.grey.lighten2
statusBarStyle = .lightContent

v.backgroundColor = Color.blue.darken2
v.depthPreset = .none

}
}
```
instruments file:

[material_leak.trace.zip](https://github.com/CosmicMind/Material/files/2879419/material_leak.trace.zip)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.