CosmWasm / CosmWasm/wasmd

Update Instantiate Config logic

Open
#1,663 2 comments 1 reaction 0 assignees View on GitHub
discussion
Dominant language
Go
Stars
416
Forks
538
PR merge metrics
No merged PRs in 30d

Description

Hi,

I've been trying to update the instantiate config to move from a multisig being allowed to a multisig + DAO, to me seems counterintuitive that this is not possible when the multisig is the "creator"/admin of the code.

```go
"anyOf < anyOf": {
superSet: AccessConfig{Permission: AccessTypeAnyOfAddresses, Addresses: []string{"owner"}},
check: AccessConfig{Permission: AccessTypeAnyOfAddresses, Addresses: []string{"other"}},
isSubSet: true,
},
"anyOf(multiple) < anyOf": {
superSet: AccessConfig{Permission: AccessTypeAnyOfAddresses, Addresses: []string{"owner"}},
check: AccessConfig{Permission: AccessTypeAnyOfAddresses, Addresses: []string{"owner", "other"}},
isSubSet: true,
},
```
I added a simple test and this 2 will fail, and I think is the IsSubSet logic is applying the checks correctly but not sure if this logic should be applied when the owner is the `creator` of the code at least not when trying to update the config.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.