ContinualAI / ContinualAI/avalanche
before_forward callback confusing naming
Open
bug
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 321
- PR merge metrics
- No merged PRs in 30d
Description
In the eval loop, before_eval_forward is called, but in the training loop, before_forward is called. It can be confusing since it's not clear whether this callback is used in the train loop or eval loop from a user point of view. Maybe we should stick to naming before_train_forward and after_train_forward just like it's done in the evaluation loop.
Contributor guide
Assessment
This issue has not been assessed yet.