ContextLab / ContextLab/orchestrator

Fix ConfigurationManager API mismatch: register_config_type vs register_config

Open
#353 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
3
Forks
2
Avg merge
13m
Merged PRs (30d)
1

Description

## Problem
The test suite for `ConfigurationManager` expects methods and attributes that don't match the actual implementation:

**Tests expect:**
- `register_config_type(name, config_class)` method
- `_config_types` attribute
- Config type registration and creation workflow

**Implementation provides:**
- `register_config(name, config_instance)` method
- `configurations` attribute
- Config instance storage workflow

## Impact
- Tests in `TestConfigurationManager` class fail/timeout due to missing methods
- API inconsistency between test expectations and implementation

## Files Affected
- `tests/core/test_wrapper_framework.py` (lines 301-340)
- `src/orchestrator/core/wrapper_config.py` (ConfigurationManager class)

## Solution Options
1. Update ConfigurationManager to match test expectations
2. Update tests to match current implementation
3. Design new unified API that serves both needs

## Priority
Medium - affects test coverage but doesn't block core functionality

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.