Consensys / Consensys/eth-lightwallet

Return the newly generated address in keystore.generateNewAddress()

Open
#98 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.5k
Forks
513
PR merge metrics
No merged PRs in 30d

Description

Can the `generateNewAddress(derivedPwKey, N)` function be modified to return the newly generated address(es) as a convenience instead of returning undefined? The most likely thing a client does after generating new address(es) is to access them. This enhancement would save the client the extra step to call `keystore.getAddresses()` and obtain the last N addresses to gain access to those new addresses.
Of course, the return would be an array type of new addresses.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at keystore.generateNewAddress(derivedPwKey, N) and inspect how it creates new addresses and how keystore.getAddresses() exposes them. Verify that the function returns an array containing the newly generated addresses for the requested count.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
blockchain
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.