Consensys / Consensys/eth-lightwallet

txParams optionally instead of rawTx

Open
#67 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.5k
Forks
513
PR merge metrics
No merged PRs in 30d

Description

i have to serialize my unsigned tx just so lightwallet can deserialize it. seems silly.

params hash is like

```
{
to: '0x1234',
from: '0x4321',
value: 100,
nonce: 0
}
```

ethereumjs-tx now also accepts web3 style tx params keys (`gasLimit` -> `gas`)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the lightwallet entry point that currently requires a rawTx and inspect how it uses ethereumjs-tx for deserialization. Done means the entry point accepts the shown transaction-parameter hash, including web3-style gas keys, without requiring callers to serialize first.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
blockchain
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.