Consensys / Consensys/Token-Factory

Change uPort provider to query accounts when activating it.

Open
#31 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
473
Forks
295
PR merge metrics
No merged PRs in 30d

Description

Metamask requires pinging accounts regularly to fetch the latest address from the extension. uPort on the other hand uses getAccounts() to fire the QR code. This is slightly incompatible as uPort would more likely have one "sign in" action vs potentially "many" from Metamask.

Thus, if using uPort, the sign in should happen and then address locally stored.

If the provider is uPort -> get address from local storage -> otherwise use getAccounts() when sending a tx.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.