ConsenSysMesh / ConsenSysMesh/web3studio-bootleg

Implement `SharedRoyaltyTokenEnumerable` extention

Open
#94 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
92
Forks
25
PR merge metrics
No merged PRs in 30d

Description

## Overview

As a developer implementing an enumerable shared royalty token, I want a contract that implements the enumerable interface so that I can be assured I'm implementing the token to spec and don't need to write common code.

### Questions
- Is everything that we want to enumerate enumerate-able?

### Reference

- [Solidity Inheritance](https://solidity.readthedocs.io/en/v0.4.24/contracts.html#inheritance)
- Contract Archetecture #78
- [Etherium NatSpec](https://github.com/ethereum/wiki/wiki/Ethereum-Natural-Specification-Format)
- [OpenZeppelin 721](https://github.com/OpenZeppelin/openzeppelin-solidity/tree/master/contracts/token/ERC721)

### Assumptions

- Delivered in `bootleg-tokens`
- Can reference OpenZeppelin's 721 implementation

### Acceptance

- SharedRoyaltyTokenEnumerable interface defined in #78 documented with NatSpec
- Tests!

Contributor guide

Open the contributing guide

Research direction

Start in the bootleg-tokens area and read Contract Architecture #78 to understand the SharedRoyaltyTokenEnumerable interface. Compare the intended interface with OpenZeppelin's ERC721 implementation and review the Ethereum NatSpec reference. Define the documented interface and add tests covering the enumerable behavior described by the project.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity
Domain
blockchain
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.