ConsenSysMesh / ConsenSysMesh/rimble-ui

Add token Icons (spike)

Open
#405 1 comment 0 reactions 1 assignee Claimed by @MikeLockz View on GitHub
Dominant language
JavaScript
Stars
455
Forks
60
PR merge metrics
No merged PRs in 30d

Description

We've been asked to add icons for tokens. There are a few different approaches to adding icons.

What are the options?

- include them in library
- does that negatively impact bundle size?
- separate rimble package of only crypto icons
- determine an approach for how to integrate with current Icon component
- does this break or extend nicely?

- rmdi package that scrapes the icons and wraps them in react components that play nice with styled-components (npm dependency)
- can we extend this process to new, custom icons?

Requirements:
- svg only (where do we find these)
- source from other open source projects
- which tokens?
- whatever decision increases the utility and use of rimble-ui
- How can we expand this to include other tokens/brands

Acceptance criteria:
- Figure out tree-shake icons
- Include RMDI + crypto icons
- try on existing `rimble-ui` library

e: 2d

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.