ConsenSysMesh / ConsenSysMesh/hooked-web3-provider

session_nonces increment issue

Open
#9 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
78
Forks
52
PR merge metrics
No merged PRs in 30d

Description

I saw that session_nonce and global nonce for a Sender X was incremented even if you enter a wrong password or if you cancel the transaction. This causes that your next transaction will be always queued.

I MOVED the row:

```
// Update caches.
session_nonces[sender] = final_nonce + 1;
_this3.global_nonces[sender] = final_nonce + 1;
```

AFTER (row 169):

```
_this3.transaction_signer.signTransaction(tx_params, function (err, raw_tx) {
if (err != null) {
return next(err);
}
```

and it solves for me.

Look at our version on github for complete file:
https://github.com/inzhoop-co/LETH/blob/master/www/lib/thirdparty/hooked-web3-provider.js

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.