ConsenSysMesh / ConsenSysMesh/hooked-web3-provider

Symbol unvailable: suggest for replacement

Open
#8 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
78
Forks
52
PR merge metrics
No merged PRs in 30d

Description

We are using hooked provider and lightwallet libs for our mobile wallet LETH (https://github.com/inzhoop-co/LETH) and we find some issues using Symbol on android devices.

```
In hooked-web3-provider.js
row 49: ... requests[Symbol.iterator]() ...
```

Symbol is unvailable for more devices so we suggest a fix with a replacement using forEach, like this :

```
requests.forEach(function(request) {
if (request.method == "eth_sendTransaction") {
throw new Error("HookedWeb3Provider does not support synchronous transactions. Please provide a callback.");
}
```

Look at our version on github for complete file:
https://github.com/inzhoop-co/LETH/blob/master/www/lib/thirdparty/hooked-web3-provider.js

Great work!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.