ConsenSysMesh / ConsenSysMesh/MultiSigWallet

getTransactionIds and getTransactionCount not working

Open
#7 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Solidity
Stars
325
Forks
146
PR merge metrics
No merged PRs in 30d

Description

When calling the getTransactionCount on the deployed contract through etherscan, it always seems to count all the transactions. To reproduce, got to for example this deployed instance of the multisig wallet and call getTransactionCount with pending=false and executed=false:
https://etherscan.io/address/0x6ADD960f63925AB6F29CC66d2349A786A3F79276#readContract
It always counts all the transactions, even though it should return 0. Similarly, getTransactionIds always returns the same result regardless of the parameters chosen.

I'm not sure where there error is. Maybe there is a problem with the line break in the "if" statement?
This could also be a problem with etherscan. Nonetheless, this might be of interest to you.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.