Concordium / Concordium/concordium-node

Unify independent constants

Open
#914 0 comments 0 reactions 0 assignees View on GitHub
[Type] Task
Dominant language
Haskell
Stars
108
Forks
24
Avg merge
2d 4h
Merged PRs (30d)
9

Description

**Task description**

There are a few constants in the network layer, in particular `PROTOCOL_MAX_MESSAGE_SIZE` and `PROTOCOL_MAX_TRANSACTION_SIZE` which should be more closely aligned with similar constants/parameters used in the scheduler/consensus.

In particular block size is now configurable indirectly via the energy parameter so ideally we'd inform max_message_size based on that.

**Sub-tasks**
- [ ] Figure out the correct way to define MAX_MESSAGE_SIZE. Note that this is important to have to prevent resource exhaustion.
- [ ] Implement

Contributor guide

Open the contributing guide

Research direction

Start by tracing the network-layer constants PROTOCOL_MAX_MESSAGE_SIZE and PROTOCOL_MAX_TRANSACTION_SIZE and comparing them with the scheduler/consensus parameters and the energy-based block-size configuration. The issue names no files or tests, so first locate those entry points and determine the safe limit required to prevent resource exhaustion. Done means the independent constants are aligned and the implementation reflects the configurable block size.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
blockchain, networking
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.