Concordium / Concordium/concordium-node

Finalizers send Freeze message before blocks they bake

Open
#759 0 comments 1 reaction 0 assignees View on GitHub
[Type] Bug
Dominant language
Haskell
Stars
108
Forks
24
Avg merge
2d 4h
Merged PRs (30d)
9

Description

**Bug Description**

When a finalizer bakes a block that is eligible for finalization, the finalizer generates and sends a Freeze message nominating the baked block before transmitting the block itself. This is not ideal, as we should expect a Freeze message that refers to an unknown block to trigger a catch-up with the sending peer, which should be avoided in normal operation. However, in fact, such messages are relayed and do not trigger a catch-up. Once the block is received, the finalization protocol is able to interpret the Freeze message as a valid nomination.

**Steps to Reproduce**

Run a node with debug level logging.

**Expected Result**

Do not observe Afgjort log messages of the form: Message refers to unjustified block; catch-up required.

**Actual Result**

Such log messages routinely occur.

**Versions**
- Software Version: all
- OS: all

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.