ComposeGears / ComposeGears/Valkyrie

FR: Add ability to resize and normalize icons during import.

Open
#173 1 comment 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
889
Forks
26
Avg merge
36m
Merged PRs (30d)
2

Description

Some designers export icons in weird sizes like 45x45 or 17x21. While we developers wage war against such crimes, we also have to cope with it by resizing icons manually on Figma to 24x24 and then exporting them through Valkyrie. If possible, add an option to resize an icon or all icons in a pack (both default* size options and the dimensions of the vector path) during import to a defined value, 24.dp by default, so that everything devs are doing on Figma can be automated:

  1. Icons have 24.dp default size
  2. Icons have 24x24 viewport and are uniformly scaled to match it
  3. Icons are resized to fit the bounding box with no padding
  4. Icons are centered in the viewport

Options 3 and 4 should be configurable if they cause problems, or can be omitted if they are take too much work

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating Valkyrie's icon import flow and the handling of default size options and vector paths; compare how imported icons currently retain their dimensions. Done means imported icons can use a defined default size, a 24x24 viewport, uniform scaling, and centering or bounding-box fitting where supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.