ComplianceAsCode / ComplianceAsCode/content

The `uefi` and `non-uefi` platforms have incoherent conditionals

Open
#13,151 0 comments 0 reactions 0 assignees View on GitHub
triaged
Dominant language
Shell
Stars
2.8k
Forks
828
Avg merge
3d 8m
Merged PRs (30d)
80

Description

#### Description of problem:

The `uefi` (and its counterpart `non-uefi`) platform has different conditionals across supported template types:

```yaml
name: cpe:/a:uefi
title: System boot mode is UEFI
# This OVAl check is based on presence of /sys/firmware/efi
check_id: system_boot_mode_is_uefi
bash_conditional: '[ -d /sys/firmware/efi ]'
ansible_conditional: '"/boot/efi" in ansible_mounts | map(attribute="mount") | list'
```
Conditionals must follow the same logic of applicability.

It might make sense to reconsider the criteria and the name. Also it makes sense to use `not uefi` platform expression instead of two platform definitions.

#### SCAP Security Guide Version:

0.1.76

Extract from #13006.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.