Possibly typo.
Open
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 742
- Forks
- 59
- PR merge metrics
- No merged PRs in 30d
Description
Thanks for the great codes.
I am not sure but the following might be typo.
0 is for x
1 is for y.
x is for W
y is for H.
So the H of the 1st line and W of the 2nd line should be swapped in this normalization ?
kptsA_np[:, 0] = kptsA_np[:, 0] / H * 2.0 - 1.0
kptsA_np[:, 1] = kptsA_np[:, 1] / W * 2.0 - 1.0
kptsB_np[:, 0] = kptsB_np[:, 0] / W_B * 2.0 - 1.0
kptsB_np[:, 1] = kptsB_np[:, 1] / H_B * 2.0 - 1.0
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at source/corr_init.py around line 392 and trace how kptsA_np and kptsB_np coordinates are defined before normalization. Compare the x/y convention with the image height and width variables to confirm whether the denominators are swapped. Done when the normalization is verified as correct or the issue is resolved with the appropriate correction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100