CommunityToolkit / CommunityToolkit/dotnet

ISettingsStorageHelper namespace incorrect

Open
#403 1 comment 1 reaction 0 assignees View on GitHub
bug :bug: Good first issue :100:
Dominant language
C#
Stars
3.8k
Forks
400
PR merge metrics
No merged PRs in 30d

Description

### Describe the bug

Not sure how this was missed, but the ISettingsStorageHelper has a different namespace than all the other helpers here:

https://github.com/CommunityToolkit/dotnet/blob/9d1a525d04299e5421cb3e5917825fee2bc11a18/CommunityToolkit.Common/Helpers/ObjectStorage/ISettingsStorageHelper.cs#L5

All the other helpers are `CommunityToolkit.Common.Helpers`...

https://github.com/CommunityToolkit/dotnet/blob/9d1a525d04299e5421cb3e5917825fee2bc11a18/CommunityToolkit.Common/Helpers/ObjectStorage/IFileStorageHelper.cs#L8

Similarly the extension helper to it has a `.Extensions`:

https://github.com/CommunityToolkit/dotnet/blob/9d1a525d04299e5421cb3e5917825fee2bc11a18/CommunityToolkit.Common/Extensions/ISettingsStorageHelperExtensions.cs#L8

Where the other extensions do not and are just part of `CT.Common`.

### Regression

_No response_

### Steps to reproduce

```text
N/A Code Quality
```

### Expected behavior

Consistency in Namespace

### Screenshots

_No response_

### IDE and version

VS 2022

### IDE version

_No response_

### Nuget packages

- [X] CommunityToolkit.Common
- [ ] CommunityToolkit.Diagnostics
- [ ] CommunityToolkit.HighPerformance
- [ ] CommunityToolkit.Mvvm (aka MVVM Toolkit)

### Nuget package version(s)

8.0.0

### Additional context

Not sure if there's other places to audit?

### Help us help you

Yes, but only if others can assist

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.