CommunityToolkit / CommunityToolkit/Windows

Surface Dial Extension Bugs

Open
#682 1 comment 0 reactions 0 assignees View on GitHub
bug components::extensions help wanted
Dominant language
C#
Stars
1.1k
Forks
166
PR merge metrics
No merged PRs in 30d

Description

## Describe the bug
Found a few issues with the Surface Dial TextBox Extensions:

- [ ] Tapping doesn't go to the next control (if you have focus on first box below, tap dial, then it doesn't go to next textbox)
- [x] ~Default Icon should be `Scroll` not `Ruler` as it is shown in menu (unlike the comment says) and...~ (didn't notice we're going to have scroll already by default, so I guess ruler is a good compromise unless we added a custom icon...
- [ ] Is `ForceMenuItem` required for this to work? It seems to be which is odd...
- [ ] Copy the TextBox in the sample and you'll see there's two (or more!) menu items in the Surface Menu... (there should only ever be a single one).

![image](https://user-images.githubusercontent.com/24302614/108782281-27ad3c80-7520-11eb-9ee3-0fa0228d7007.png)

## Steps to Reproduce

Sample App:
```xml


```

## Expected behavior
Tapping should go to the next tab order control. Menu item should only appear a single time ever when the textbox has focus. If it can work without the `ForceMenuItem` property it should, otherwise this property seems useless, should it just be `ShowMenuItem`?

## Environment
Existing 6.1 Sample App.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.