CommunityToolkit / CommunityToolkit/Windows

Problems with InternalsVisibleTo

Open
#441 1 comment 0 reactions 1 assignee Claimed by @Arlodotexe View on GitHub
bug nativeaot
Dominant language
C#
Stars
1.1k
Forks
166
PR merge metrics
No merged PRs in 30d

Description

Worth noting our use of [`InternalsVisibleTo`](https://github.com/search?q=repo%3ACommunityToolkit%2FWindows%20InternalsVisibleTo&type=code) are using or being used by same set of components that keep appearing in these issues-- Behaviors, Animations, Media and Extensions.

If our use of `InternalsVisibleTo` is indeed related to our AoT issues on Wasdk as well as what we've seen here regarding transient dependencies, it might be highlighting a deeper issue with how we've set up these libraries.

We might want to go through and see if we can remove the need for these `InternalsVisibleTo`, it looks like at least a few are just to avoid helper duplication. If it fixes any of the issues we've listed throughout this ticket, we've narrowed the scope of our search down considerably.

_Originally posted by @Arlodotexe in https://github.com/CommunityToolkit/Windows/issues/169#issuecomment-2181688627_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.