CommunityToolkit / CommunityToolkit/MVVM-Samples

MVVM Toolkit Sample App - Stance on IoC class

Open
#96 0 comments 4 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
1.4k
Forks
265
PR merge metrics
No merged PRs in 30d

Description

Im a bit confused about the sample apps stance on the Ioc class.
On the introduction page, the Ioc class is mentioned
![image](https://user-images.githubusercontent.com/76792853/183216421-46005ea3-5319-4340-a966-60b6930196c7.png)
However the rest of the app seems to deny its existence. For example, on the Inversion of Control page, its stated there that the toolkit provides no APIs to facilitate ioc or dependency injection or constructor injection (however does provide a link to the IOC class right below that, but then in the example below _that_ it sets up the IServiceProvider in the app.xaml.cs and uses App.Current to get access to the service provider statically, rather than the Ioc class).
Similarly in the Settings Service page, it states "It is also possible to use other patterns, such as the service locator pattern, but the MVVM Toolkit does not offer built-in APIs to enable that.", but thats _exactly_ what the IoC class does, it provides a mechanism almost solely to simplify the service locator pattern.

Dont get me wrong, i dont _like_ the IoC class, personally, but im a bit confused on the mixed messaging here in the sample app.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.