CommunityToolkit / CommunityToolkit/Labs-Windows

Clean up suppression of CA1063 and implement IDisposable correctly

Open
#443 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C#
Stars
482
Forks
89
PR merge metrics
No merged PRs in 30d

Description

From https://github.com/CommunityToolkit/Tooling-Windows-Submodule/issues/63

One or more components in this repository are suppressing CA1063. To avoid memory leaks in certain edge cases, we should be implementing the full `IDisposable` pattern and not suppressing this warning.

Affected components:
- [AppServices](https://github.com/CommunityToolkit/Labs-Windows/blob/073e60f871e1861f33feefe52d8a5bbe101bedcd/components/AppServices/src/AppServiceComponent.cs#L17)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.