CommunityToolkit / CommunityToolkit/Graph-Controls

MsalProvider constructor crashes unless you pass scopes

Open
#195 1 comment 0 reactions 0 assignees View on GitHub
Area: Providers
Dominant language
C#
Stars
156
Forks
38
PR merge metrics
No merged PRs in 30d

Description

https://github.com/CommunityToolkit/Graph-Controls/blob/d985141a317c96ad571bd9dd8097e38969b649d6/CommunityToolkit.Authentication.Msal/MsalProvider.cs#L63

the default value for scopes is null, but we unconditionally run the `Select(...)` on it. Fix would be to either not provide a default argument for scopes (since it's arguably needed), or at least use `scopes?.Select(...)` so that we don't end up with a null deref.
note there's 2 ctors with this issue

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.