CommunityToolkit / CommunityToolkit/Graph-Controls

MsalProvider.cs ctors convert scope strings to lowercase but should not do that!

Open
#185 1 comment 1 reaction 0 assignees View on GitHub
Area: Providers bug :bug:
Dominant language
C#
Stars
156
Forks
38
PR merge metrics
No merged PRs in 30d

Description

Toolkit Version 7.1.1

MsalProvider.cs Contructors convert the scope arrays to lowercase:

`Scopes = scopes.Select(s => s.ToLower()).ToArray() ?? new string[] { string.Empty };`

It should not do this because OpenID specs define scopes as CASE SENSITIVE.
https://openid.net/specs/openid-connect-core-1_0.html#ScopeClaims
"_Multiple scope values MAY be used by creating a space delimited, **case sensitive** list of ASCII scope values_."

https://tools.ietf.org/html/rfc6749#section-3.3
"_The value of the scope parameter is expressed as a list of space-delimited, **case-sensitive** strings. The strings are defined by the authorization server. If the value contains multiple space-delimited strings, their order does not matter, and each string adds an additional access range to the requested scope._"

I'm running an .NET Core 6 Azure Web App Api with an case sensitive scope in the AAD app registration. Using standard MSAL PublicClientApplication runs fine with that. Using the MsalProvider wrapper of the community toolkit breaks this, because the "lowercased" scope is not accepted by Microsoft.IdentityModel.Tokens.SecurityToken:

_IDX10214: Audience validation failed. Audiences: 'https://abce.de/webapp-abcd.azurewebsites.net'. Did not match: validationParameters.ValidAudience: 'https://abce.de/WebApp-abce.azurewebsites.net'_

Please not the uppercase 'W' in the scope.

**Earlier versions of MSAL also had that bug and fixed it:**
https://github.com/AzureAD/microsoft-authentication-library-for-objc/issues/395
https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/1922

Best Regards,
Torsten

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.