CommunityToolkit / CommunityToolkit/AI

Make Azure SQL tests conditional

Open
#20 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
7
Forks
4
Avg merge
5h 54m
Merged PRs (30d)
8

Description

In https://github.com/CommunityToolkit/AI/pull/16, we have added CommunityToolkit.VectorData.SqlServer with some workarounds related to not running the tests against SQL Server docker container which tests features currently available only for Azure SQL Server.

https://github.com/CommunityToolkit/AI/blob/e966e4f56b1ec2ded2a5bbeb0c723ab05f4b28d9/MEVD/test/SqlServer.ConformanceTests/SqlServer.ConformanceTests.csproj#L14-L17

https://github.com/CommunityToolkit/AI/blob/e966e4f56b1ec2ded2a5bbeb0c723ab05f4b28d9/MEVD/test/SqlServer.ConformanceTests/SqlServerIndexKindTests.cs#L22-L26

Those tests need to be conditional, but this will require a new version of the Conformance Tests package (https://github.com/dotnet/extensions/issues/7605)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.