Comfy-Org / Comfy-Org/wheels

FlashAttention 3

Open
#10 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
16
Forks
8
PR merge metrics
No merged PRs in 30d

Description

FlashAttention 3 exists and surprisingly not many people know it. It's mainly advertised to be fast on sm90 (H100), and in my benchmarks it's indeed a bit faster than FA2 on sm86 (RTX 3080), so it helps on consumer GPUs.

Some FA3 wheels are available at https://download.pytorch.org/whl/flash-attn-3/ . See the discussion in https://github.com/Dao-AILab/flash-attention/pull/2223 . The only thing missing is that they could not build wheel with Windows + cu130, and it has been fixed with the patch in https://github.com/windreamer/flash-attention3-wheels . This is worth tracking for us.

After we have the wheels, we can replace FA2 with FA3 on supported GPUs in ComfyUI.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the FlashAttention discussion at https://github.com/Dao-AILab/flash-attention/pull/2223 and the Windows wheel patch at https://github.com/windreamer/flash-attention3-wheels. Identify how the available wheels and supported GPUs map to this wheels repository. Done means FA3 wheels are available for the needed platforms and supported GPUs can use FA3 in place of FA2.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
build-system, machine-learning
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.