Comfy-Org / Comfy-Org/comfy-api-proxy

issues with base url generation

Open
#31 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
11
Forks
5
Avg merge
1d 6h
Merged PRs (30d)
3

Description

Behind a tls-terminating proxy like traefik, a https job submission to the proxy returns links to http endpoints, not https.

Some sort of x-forwarded-proto/host support from trusted proxies or an `--external-base-url` argument might be helpful there, otherwise even if there is a http path, most clients see it as a different origin and drop the bearer token.

```
POST https://comfy-proxy.example/api/v2/jobs HTTP/1.1
Host: comfy-proxy.example
Authorization: Bearer
Content-Type: application/json
Idempotency-Key:

{
"workflow": {
"": ""
}
}

HTTP/1.1 201 Created
Content-Type: application/json

{
"id": "",
"status": "queued",
"outputs": [],
"urls": {
"self": "http://comfy-proxy.example/api/v2/jobs/",
"events": "http://comfy-proxy.example/api/v2/jobs//events",
"cancel": "http://comfy-proxy.example/api/v2/jobs//cancel"
}
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.