Comfy-Org / Comfy-Org/ComfyUI_frontend

refactor: extract shared PerfMeasurement interface across tsconfig projects

Open
#9,960 0 comments 0 reactions 0 assignees View on GitHub
developer experience
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

## Context

The `PerfMeasurement` interface is defined independently in two files that live in separate tsconfig projects:
- `browser_tests/fixtures/helpers/PerformanceHelper.ts`
- `scripts/perf-report.ts`

When new metrics are added (e.g. `totalBlockingTimeMs`, `frameDurationMs`), both copies must be updated manually.

## Proposed Solution

Extract the interface to a shared `.d.ts` file that both tsconfig projects can reference, eliminating the duplication.

## Origin

Identified during PR #9910 review (thread on `PerformanceHelper.ts:30`).

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-9960-refactor-extract-shared-PerfMeasurement-interface-across-tsconfig-projects-3246d73d365081a4b7ccf97554b17c6d) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.