Comfy-Org / Comfy-Org/ComfyUI_frontend

fix: update .claude/settings.json Vitest permission targets to match real draftCacheV2 test file

Open
#9,802 0 comments 0 reactions 1 assignee Claimed by @christian-byrne View on GitHub
area:testing developer experience
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

## Summary

The Vitest permission entries in `.claude/settings.json` currently reference a non-existent test target (`draftCacheV2.property`):

```json
"Bash(pnpx vitest run --testPathPattern=\"draftCacheV2.property\")",
"Bash(pnpx vitest run \"draftCacheV2.property\")"
```

The actual test file is `src/platform/workflow/persistence/base/draftCacheV2.test.ts`. These mismatched targets prevent Claude from running the real cache tests despite the permissions appearing to allow it.

## Proposed fix

Update both entries to target the real test file, e.g.:
- `--testPathPattern="draftCacheV2.test.ts"` (or simply `--testPathPattern="draftCacheV2"`)
- Adjust the second command accordingly.

## Context

- Identified in PR #9744 (review comment): https://github.com/Comfy-Org/ComfyUI_frontend/pull/9744#discussion_r2924517938
- Requested as a follow-up by @christian-byrne — the `.claude/settings.json` change in that PR was solely to exclude the file from knip scans; the mismatched permissions are pre-existing.

## Requester

@christian-byrne

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-9802-fix-update-claude-settings-json-Vitest-permission-targets-to-match-real-draftCacheV2-3216d73d365081e6b324ed4bfb0ce44c) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.