Comfy-Org / Comfy-Org/ComfyUI_frontend

Add error logging for persistence failures in docked job history toggle

Open
#9,268 0 comments 0 reactions 1 assignee Claimed by @christian-byrne View on GitHub
area:queue
Dominant language
TypeScript
Stars
2k
Forks
702
Avg merge
1d 8h
Merged PRs (30d)
512

Description

## Context

In PR #9265, the `onToggleDockedJobHistory` function was updated to use a try/catch block that silently swallows persistence errors. While this is safe for users (since the local UI state is already applied before the await), adding error logging would make it easier to diagnose persistence issues in production without affecting the UX.

## Proposal

Add `console.warn` or Sentry tracking in the catch block to log persistence failures for debugging purposes.

## References

- PR: https://github.com/Comfy-Org/ComfyUI_frontend/pull/9265
- Review comment: https://github.com/Comfy-Org/ComfyUI_frontend/pull/9265#discussion_r2862083603
- Requested by: @christian-byrne

## File Location

`src/components/queue/JobHistoryActionsMenu.vue`

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-9268-Add-error-logging-for-persistence-failures-in-docked-job-history-toggle-3146d73d365081cc9dbdc894dfb3b883) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.