Comfy-Org / Comfy-Org/ComfyUI_frontend

Implement Vue-based spinner for image upload in Nodes 2.0 mode

Open
#9,227 1 comment 0 reactions 1 assignee Claimed by @christian-byrne View on GitHub
area:nodes area:ui area:vue-migration
Dominant language
TypeScript
Stars
2k
Forks
704
Avg merge
1d 8h
Merged PRs (30d)
512

Description

## Context

Currently, PR #9189 implements a canvas-based loading spinner for image uploads in LoadImage nodes. However, when `vueNodesMode` is enabled, `drawNode` skips all canvas rendering (LGraphCanvas line 5396-5403), making the spinner invisible in Nodes 2.0.

## Task

Implement a Vue-based spinner for the image preview overlay that works with Nodes 2.0 compatibility.

## References

- PR: https://github.com/Comfy-Org/ComfyUI_frontend/pull/9189
- Comment: https://github.com/Comfy-Org/ComfyUI_frontend/pull/9189#discussion_r2856396701
- Requested by: @christian-byrne

## Implementation Notes

The Vue-based spinner should:
- Display during image upload operations
- Be visible when vueNodesMode is enabled
- Integrate with the existing image preview overlay component
- Maintain consistency with the current upload UX (filename updates, etc.)

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-9227-Implement-Vue-based-spinner-for-image-upload-in-Nodes-2-0-mode-3136d73d365081c7a3c4e7a9f47f5434) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.