Comfy-Org / Comfy-Org/ComfyUI_frontend

Enhance ID validation using Zod 4 format validators

Open
#7,273 0 comments 0 reactions 1 assignee Claimed by @DrJKL View on GitHub
Public API
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

After upgrading to Zod 4, revisit ID field validation in the Jobs API types to use stricter format validators.

**Context:**
The Jobs API types in `src/platform/remote/comfyui/jobs/jobTypes.ts` currently use `z.string()` for ID fields. Zod 4 introduces standalone format validators (`z.uuid()`, `z.ulid()`, `z.cuid2()`, `z.nanoid()`) that would provide stricter runtime validation and better error messages.

**Affected fields:**
- `id` in `zRawJobListItem`
- `prompt_id` in `zExecutionError`
- `node_id` in `zExecutionError`
- `workflow_id` in `zRawJobListItem`

**Prerequisite:**
This enhancement requires upgrading from Zod 3 (currently ^3.23.8) to Zod 4.

**Related:**
- PR: https://github.com/Comfy-Org/ComfyUI_frontend/pull/7169
- Discussion: https://github.com/Comfy-Org/ComfyUI_frontend/pull/7169#discussion_r2600426728
- Requested by: @DrJKL

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-7273-Enhance-ID-validation-using-Zod-4-format-validators-2c46d73d3650811daedffe28b6f6af68) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.