Comfy-Org / Comfy-Org/ComfyUI_frontend

Errors generated in console when executing one graph and viewing another

Open
#6,730 1 comment 1 reaction 0 assignees View on GitHub
area:subgraph Potential Bug
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

### Prerequisites

- [x] I am running the latest version of ComfyUI
- [x] I have searched existing issues to make sure this isn't a duplicate
- [x] I have tested with all custom nodes disabled ([see how](https://docs.comfy.org/troubleshooting/custom-node-issues#step-1%3A-test-with-all-custom-nodes-disabled))

### What happened?

When you are running a workflow, and viewing another workflow, when the node being executed is within a subgraph, the console gets spammed with errors

### Steps to Reproduce

1. Create a workflow, place the KSampler into a subgraph
2. Run the workflow
3. While it is running, open a different workflow (in the same browser tab, a new tab within Comfy)
4. Look at the console

### How is this affecting you?

Minor inconvenience

### ComfyUI Frontend Version

1.28.8

### Browser

Chrome/Chromium

### Console Errors

```javascript
Uncaught Error: Subgraph not found: 225
at getSubgraphsFromInstanceIds (executionStore.ts:70:24)
at Proxy.executionIdToNodeLocatorId (executionStore.ts:92:21)
at wrappedAction (pinia.mjs:1405:26)
at Proxy.revokePreviewsByExecutionId (imagePreviewStore.ts:247:27)
at wrappedAction (pinia.mjs:1405:26)
at ComfyApi.handleProgressState (executionStore.ts:321:9)
at ComfyApi.dispatchCustomEvent (api.ts:378:18)
at WebSocket. (api.ts:550:20)
```

### Logs

```shell

```

### Additional Context

Looks like the code is looking for the node_id provided by a progress update event. If this is of the form x:y for a node in a subgraph, the subgraph doesn't exist in the currently visible workflow.

There is a more general issue here though - messages from the server really ought to include an id for the workflow that they are relevant to. Perhaps the top level graph id could be used for this.

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-6730-Errors-generated-in-console-when-executing-one-graph-and-viewing-another-2af6d73d365081239812cd0c6967bef3) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.