Comfy-Org / Comfy-Org/ComfyUI_frontend

[perf] Performance in new Vue Nodes system is bottlenecked by interactions/events

Open
#6,151 0 comments 1 reaction 0 assignees View on GitHub
area:nodes area:ui area:vue-migration perf:speed
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

This is a good thing, because it's one of the easiest things to fix.

If I load a workflow with a huge number of nodes and images, the performance seems to degrade during navigation.

However, if I navigate with the minimap, I can get the performance again from the early days (60 fps on giant graphs).

To me, this suggests there's some huge bottle necks in the interaction/event handling on transform pane and its children. As using the minimap to navigate involves all the same systems as it relates to rendering - the only difference is the interaction flow.

This aligns with the previous profiling done showing event listener bottlenecks.

It's good that the performance can still be quite good after we clean this up. I.e., we are just a few optimizations away from restoring the original performance which generally out-competes all DOM based competitor at least for navigation.

https://github.com/user-attachments/assets/4e7eecc9-0b6e-4cf0-bed5-15dbbb5034eb

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-6151-perf-Performance-in-new-Vue-Nodes-system-is-bottlenecked-by-interactions-events-2916d73d365081ecbcb7ce8969c7df7c) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.