Comfy-Org / Comfy-Org/ComfyUI_frontend
Prepush Knip Checks Unstaged
Open
area:CI/CD
developer experience
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 699
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 490
Description
1. A developer tries to push
2. They see knip crying
3. They fix the issue
4. They push again
5. Push succeeds
6. CI knip fails
cause: fix was never staged, but knip still checked it
what do we think about moving this to lint-staged meant for pre-commit?
cons
- longer commit times
pros
- lower cognitive load
┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-5443-Prepush-Knip-Checks-Unstaged-2686d73d365081489497c5acc5f5a5d0) by [Unito](https://www.unito.io)
Contributor guide
Assessment
This issue has not been assessed yet.