Comfy-Org / Comfy-Org/ComfyUI_frontend

Make layout operations atomic

Open
#5,353 0 comments 0 reactions 1 assignee Claimed by @christian-byrne View on GitHub
area:nodes
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

In vue nodes layout tree, certain operations can affect multiple systems like layout CRDT, graph data model, litegraph, spatial index.

These operations are already wrapped in transactions for the purpose of CRDT atomicity, but there's no rollback implemented for the other systems' side-effects. To actually make it atomic, we'd need either:

1. Make the other operations (e.g., changes to Litegraph or spatial index) reversible/rollback-able
2. Store everything inside the CRDT
3. User a proper transaction coordinator

One of these should be established now so it doesn't need to be done later.

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-5353-Make-layout-operations-atomic-2646d73d365081e1966ee1398b788606) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.